Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correspond to commonmarker v1 #31

Merged
merged 6 commits into from
May 7, 2024
Merged

Correspond to commonmarker v1 #31

merged 6 commits into from
May 7, 2024

Conversation

moekiorg
Copy link
Contributor

@moekiorg moekiorg commented Mar 4, 2024 •
edited
Loading

resolves #33

@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch 4 times, most recently from 3c6a060 to 28ec024 Compare March 4, 2024 03:06
@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch from 28ec024 to c133af4 Compare March 4, 2024 03:15
@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch from c133af4 to 3e2cd51 Compare March 4, 2024 03:16
@moekiorg moekiorg self-assigned this Mar 4, 2024
@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch 4 times, most recently from 4795de7 to 65cc295 Compare March 4, 2024 04:06
@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch from 65cc295 to 512008a Compare March 4, 2024 04:07
@moekiorg moekiorg closed this Mar 4, 2024
@moekiorg moekiorg reopened this May 6, 2024
@moekiorg moekiorg closed this May 6, 2024
@moekiorg moekiorg deleted the correspond_to_commonmarker_v1 branch May 6, 2024 22:55
@moekiorg moekiorg restored the correspond_to_commonmarker_v1 branch May 6, 2024 22:55
@moekiorg moekiorg reopened this May 6, 2024
@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch from 41ece5f to 4bef1f3 Compare May 6, 2024 23:29
moekiorg
moekiorg commented May 6, 2024
View reviewed changes
lib/mato/config.rb
Comment on lines +18 to +20
tasklist: false,
shortcodes: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is true

@moekiorg moekiorg force-pushed the correspond_to_commonmarker_v1 branch from 4bef1f3 to e935903 Compare May 6, 2024 23:37
@moekiorg moekiorg marked this pull request as ready for review May 6, 2024 23:38
moekiorg
moekiorg commented May 6, 2024
View reviewed changes
.github/workflows/reviewdog.yml

- name: Use ruby
uses: ruby/setup-ruby@v1
with:
bundler-cache: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache by default

@mugijiru mugijiru self-requested a review May 7, 2024 06:26
mugijiru
mugijiru approved these changes May 7, 2024
View reviewed changes
Copy link

@mugijiru mugijiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moekiorg moekiorg merged commit ea92cdd into master May 7, 2024
5 checks passed
@moekiorg moekiorg deleted the correspond_to_commonmarker_v1 branch May 7, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugijiru mugijiru mugijiru approved these changes

Assignees

@moekiorg moekiorg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commonmarker v1
2 participants
@moekiorg @mugijiru